Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auth's AccountDecoder type #4588

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Remove auth's AccountDecoder type #4588

merged 2 commits into from
Jun 19, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 19, 2019

AccountDecoder is now entirely redundant.
client package now does no longer depend on x/auth.

Context: #4488

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio
Remove auth's AccountDecoder type.
6541b63 
AccountDecoder is now entirely redundant.
client package now does no longer depend on x/auth.

Context: #4488
@alessio alessio requested review from sabau and fedekunze June 19, 2019 12:49
@alessio alessio changed the title Remove auth's AccountDecoder type. Remove auth's AccountDecoder type Jun 19, 2019
@alessio alessio merged commit c530c1c into master Jun 19, 2019
@alessio alessio deleted the alessio/remove-account-decoder branch June 19, 2019 14:20
alexanderbez
alexanderbez approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @jackzampolin @fedekunze